chore: rewrite HTML tables in migrating-4.mdx to markdown - #2485
Conversation
Markdown tables are automatically wrapped in .table-scroller div, but raw HTML tables have to be wrapped manually. Tables in migrating-4.mdx were simple an have been rewritten using markdown syntax.
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
One thing that I noticed while making these changes: #2221 removed a table from 5.x writing middleware docs, but left it in 4.x. The table served as an explanation of some things shown on an illustration, but the illustration has been updated to include these descriptions, so 4.x version is labelled twice. 
|
ShubhamOulkar
left a comment
ShubhamOulkar
left a comment
There was a problem hiding this comment.
#2493 fixes scrolling issues, also we discussed on rewriting to markdown tables. migrating-4 tables are in markdown, if you want then do it for tables on behind-proxies page. Removing manual addition of table-scroller is essential before merging the PR.
This will be handled by expressjs#2493
krzysdz
changed the title
migrating-4.mdx to markdown
|
Removed the manually added I looked for inline HTML and other than this (cannot be removed), some other HTML that can't be removed (e.g. links wrapping Astro components) it can be found only in:
|
2 participants
Tables in
migrating-4.mdxare simple an have been rewritten using markdown syntax, which makes them work better with plugins (the HTML was missing<thead>and<tbody>).The tables in "Express behind proxies" are quite large and contain a lot embedded markdown (code blocks, lists). Unfortunately, as far as I know it is not possible to write a markdown table with lists or code blocks without using HTML for either the table or the content.