[TASK] Use late static bindings to access AJAX_CART_TYPE_NUM from ext… #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ended ProductController AJAX_CART_TYPE_NUM sets the typeNum to 2278001. For cases where two different carts are needed, another typeNum has to be registered. To accomplish that, one can extend the ProductController just to define another AJAX_CART_TYPE_NUM and use the original methods. But that only works, if the comparison in line 107 (v10) does not read self::AJAX_CART_TYPE_NUM but static::AJAX_CART_TYPE_NUM Resolves: extcode#705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AJAX_CART_TYPE_NUM sets the typeNum to 2278001. For cases where two different carts are needed, another typeNum has to be registered. To accomplish that, one can extend the ProductController just to define another AJAX_CART_TYPE_NUM and use the original methods. But that only works, if the comparison in line 107 (v10) does not read self::AJAX_CART_TYPE_NUM but static::AJAX_CART_TYPE_NUM
Resolves: #705