feat: Add CORS preflight handler#100
Merged
Merged
Conversation
Reduce cognitive complexity of the predicate corsPreflightHandler overload by extracting requireHeader / isPreflightAllowed / parseMethodOrNull / requestedHeadersAllowed / buildPreflightSuccess helpers. Introduce an ALLOW constant for the repeated header name. Mark the swallowed parse exception with an unnamed pattern. Hoist throwing argument expressions out of assertThatThrownBy lambdas so each lambda has a single risky call.
Move corsPreflightHandler out of Handlers into a dedicated Cors class with the simpler API Cors.preflightHandler(...). The Handlers class is left to truly handler-shaped factories (alive, health, resource, default exception handler). Renames CorsPreflightHandlerTest to CorsTest. README and call sites updated accordingly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handlers.corsPreflightHandler(...)with two overloads (List<String>of origins andPredicate<String>) for answering CORSOPTIONSpreflight requests; wire viaextraRoute("/api/**", ...).Test plan
mvn verifypasses (68 IT, 0 failures)CorsPreflightHandlerTest22/22 green