refactor: Resolve open SonarCloud issues#112
Merged
Merged
Conversation
Clear the open issues reported on the default branch: - java:S8714 (assertDoesNotThrow): replace try/catch + fail() blocks in OpenApiServerIT and ServerBaseTest with assertDoesNotThrow(...). - java:S8694 (Month enum): use java.time.Month constants in GsonJsonMapperTest instead of int month literals. - java:S109 (magic numbers): name the 4xx status bounds in BadRequestException (MIN/MAX_CLIENT_ERROR_STATUS). - java:S8433 (validation before super()): validate the status range before the super() call using a flexible constructor body. No behaviour change; test-only refactors plus an equivalent constructor reordering covered by BadRequestExceptionTest.
thced
force-pushed
the
chore/sonar-open-issues
branch
from
5a2930c to
507b908
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the open issues reported on the SonarCloud default branch (
extenda_openapi-httpserver-java).What
java:S8714try/catch+fail()withassertDoesNotThrow(...)inOpenApiServerITandServerBaseTest(all 28 IT blocks converted, 2 of which Sonar had not yet flagged).java:S8694java.time.Monthconstants instead of int month literals inGsonJsonMapperTest.java:S109MIN/MAX_CLIENT_ERROR_STATUS) inBadRequestException.java:S8433super()via a flexible constructor body (JEP 513).Notes
BadRequestExceptionTest(invalid-status and null-detail paths).mvn verifyis green locally: 534 unit tests + 68 IT, 0 failures.