fix: Reject string-to-number coercion in type validation#48
Merged
Conversation
JSON Schema 'type' refers to the JSON value's intrinsic kind, not whether
its lexical form is parseable to another type. DefaultValidator was parsing
numeric-looking strings as integers/numbers, which broke oneOf branches
mixing string and number (both matched) and silently accepted strings for
plain {"type": "number"} fields.
Validator is now strict; parameter values (always strings on the wire) are
coerced to the schema's primitive type in RequestPreparationFilter before
validation runs.
thced
force-pushed
the
fix/json-schema-type-no-coercion
branch
from
78205ba to
2c2fcf4
Compare
Reduces visual noise at mock call sites and addresses three Sonar 'add at least one assertion' findings in the new coercion happy-path tests by verifying the downstream chain was invoked.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Schema 'type' refers to the JSON value's intrinsic kind, not whether its lexical form is parseable to another type. DefaultValidator was parsing numeric-looking strings as integers/numbers, which broke oneOf branches mixing string and number (both matched) and silently accepted strings for plain {"type": "number"} fields.
Validator is now strict; parameter values (always strings on the wire) are coerced to the schema's primitive type in RequestPreparationFilter before validation runs.