Skip to content

fix: Add missing extensions arg to constructors in new coercion tests #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thced merged 1 commit into from
May 12, 2026
Merged

fix: Add missing extensions arg to constructors in new coercion tests #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/test/java/com/retailsvc/http/internal/RequestPreparationFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,16 @@ void invalidQueryParamThrowsValidation() {

@Test
void integerQueryParamIsCoercedFromStringBeforeValidation() throws Exception {
var intSchema = new IntegerSchema(Set.of(TypeName.INTEGER), 1L, 100L, null, null, null, null);
var intSchema =
new IntegerSchema(Set.of(TypeName.INTEGER), 1L, 100L, null, null, null, null, Map.of());
var op =
new Operation(
"a",
HttpMethod.GET,
PathTemplate.compile("/x"),
Optional.empty(),
List.of(new Parameter("n", Parameter.Location.QUERY, true, intSchema)),
Map.of(),
Map.of());
Spec spec = specWith(op);
Filter f = newFilter(spec);
Expand All @@ -184,14 +186,16 @@ void integerQueryParamIsCoercedFromStringBeforeValidation() throws Exception {

@Test
void integerQueryParamRejectsNonNumericString() {
var intSchema = new IntegerSchema(Set.of(TypeName.INTEGER), null, null, null, null, null, null);
var intSchema =
new IntegerSchema(Set.of(TypeName.INTEGER), null, null, null, null, null, null, Map.of());
var op =
new Operation(
"a",
HttpMethod.GET,
PathTemplate.compile("/x"),
Optional.empty(),
List.of(new Parameter("n", Parameter.Location.QUERY, true, intSchema)),
Map.of(),
Map.of());
Spec spec = specWith(op);
Filter f = newFilter(spec);
Expand All @@ -205,14 +209,16 @@ void integerQueryParamRejectsNonNumericString() {

@Test
void numberQueryParamIsCoercedFromStringBeforeValidation() throws Exception {
var numSchema = new NumberSchema(Set.of(TypeName.NUMBER), null, null, null, null, null, null);
var numSchema =
new NumberSchema(Set.of(TypeName.NUMBER), null, null, null, null, null, null, Map.of());
var op =
new Operation(
"a",
HttpMethod.GET,
PathTemplate.compile("/x"),
Optional.empty(),
List.of(new Parameter("n", Parameter.Location.QUERY, true, numSchema)),
Map.of(),
Map.of());
Spec spec = specWith(op);
Filter f = newFilter(spec);
Expand All @@ -225,14 +231,16 @@ void numberQueryParamIsCoercedFromStringBeforeValidation() throws Exception {

@Test
void numberQueryParamRejectsNonNumericString() {
var numSchema = new NumberSchema(Set.of(TypeName.NUMBER), null, null, null, null, null, null);
var numSchema =
new NumberSchema(Set.of(TypeName.NUMBER), null, null, null, null, null, null, Map.of());
var op =
new Operation(
"a",
HttpMethod.GET,
PathTemplate.compile("/x"),
Optional.empty(),
List.of(new Parameter("n", Parameter.Location.QUERY, true, numSchema)),
Map.of(),
Map.of());
Spec spec = specWith(op);
Filter f = newFilter(spec);
Expand All @@ -246,14 +254,15 @@ void numberQueryParamRejectsNonNumericString() {

@Test
void booleanQueryParamCoercesTrueAndFalse() throws Exception {
var boolSchema = new BooleanSchema(Set.of(TypeName.BOOLEAN));
var boolSchema = new BooleanSchema(Set.of(TypeName.BOOLEAN), Map.of());
var op =
new Operation(
"a",
HttpMethod.GET,
PathTemplate.compile("/x"),
Optional.empty(),
List.of(new Parameter("b", Parameter.Location.QUERY, true, boolSchema)),
Map.of(),
Map.of());
Spec spec = specWith(op);
Filter f = newFilter(spec);
Expand All @@ -270,14 +279,15 @@ void booleanQueryParamCoercesTrueAndFalse() throws Exception {

@Test
void booleanQueryParamRejectsNonBooleanString() {
var boolSchema = new BooleanSchema(Set.of(TypeName.BOOLEAN));
var boolSchema = new BooleanSchema(Set.of(TypeName.BOOLEAN), Map.of());
var op =
new Operation(
"a",
HttpMethod.GET,
PathTemplate.compile("/x"),
Optional.empty(),
List.of(new Parameter("b", Parameter.Location.QUERY, true, boolSchema)),
Map.of(),
Map.of());
Spec spec = specWith(op);
Filter f = newFilter(spec);
Expand Down
5 changes: 3 additions & 2 deletions src/test/java/com/retailsvc/http/validate/StringIntegerNumberTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,15 +349,16 @@ void numberFormatUnknownIsIgnored() {
@Test
void integerRejectsNumericLookingString() {
IntegerSchema s =
new IntegerSchema(Set.of(TypeName.INTEGER), null, null, null, null, null, null);
new IntegerSchema(Set.of(TypeName.INTEGER), null, null, null, null, null, null, Map.of());
assertThatThrownBy(() -> v.validate("42", s, "/v"))
.extracting(t -> ((ValidationException) t).error().keyword())
.isEqualTo("type");
}

@Test
void numberRejectsNumericLookingString() {
NumberSchema s = new NumberSchema(Set.of(TypeName.NUMBER), null, null, null, null, null, null);
NumberSchema s =
new NumberSchema(Set.of(TypeName.NUMBER), null, null, null, null, null, null, Map.of());
assertThatThrownBy(() -> v.validate("1234567890", s, "/v"))
.extracting(t -> ((ValidationException) t).error().keyword())
.isEqualTo("type");
Expand Down
Loading