perf: Avoid throwing ValidationExceptions in happy flow#50
Merged
Conversation
Tests added in the JSON Schema type-coercion fix used the pre-extensions record signatures and stopped compiling after the OpenAPI extensions feature merged into master.
…Optional returns JFR profiling under load showed ~267 ValidationException throws/sec on the happy path — oneOf/anyOf branch selection was catching exceptions to determine which branch matched, paying allocation + stack-walk cost for every non-matching branch even when the request ultimately succeeded. Internal validation now returns Optional<ValidationError> and branch selection inspects the result. ValidationException is constructed at most once per request, only at the public validate() boundary when real validation has failed. A static counter on ValidationException makes the contract observable and testable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.