Skip to content

fix: Unbox Boolean pattern variable before ternary in SchemaParser #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thced merged 1 commit into from
May 18, 2026
Merged

fix: Unbox Boolean pattern variable before ternary in SchemaParser #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/com/retailsvc/http/spec/schema/SchemaParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ static Map<String, Object> extractExtensions(Map<String, Object> raw) {

public static Schema parse(Object raw) {
if (raw instanceof Boolean b) {
return b ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
boolean allow = b;
return allow ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
}
if (raw instanceof Map<?, ?> map) {
@SuppressWarnings("unchecked")
Expand Down Expand Up @@ -208,7 +209,8 @@ private static ArraySchema parseArray(Map<String, Object> raw, Set<TypeName> typ
if (itemsRaw == null) {
itemSchema = new NullSchema(Map.of());
} else if (itemsRaw instanceof Boolean b) {
itemSchema = b ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
boolean allow = b;
itemSchema = allow ? new AlwaysSchema(Map.of()) : new NeverSchema(Map.of());
} else {
Map<String, Object> items = (Map<String, Object>) itemsRaw;
itemSchema = items.isEmpty() ? new NullSchema(Map.of()) : parse(items);
Expand Down
Loading