feat: Replace specHandler with streaming resourceHandler#84
Merged
Conversation
Adds Handlers.resourceHandler(String) and Handlers.resourceHandler(Path) that stream from classpath or filesystem with handler-owned stream lifecycle. Existence and length are resolved at construction; the underlying stream is opened and closed per request, avoiding the try-with-resources-closes-too-early trap with lazy Response.stream writers. Replaces the eager byte-buffering specHandler and removes the internal ClasspathResourceHandler. Content-Type inference now also covers .html, .css, and .js.
sasjo
approved these changes
May 20, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Handlers.resourceHandler(String) and Handlers.resourceHandler(Path) that stream from classpath or filesystem with handler-owned stream lifecycle. Existence and length are resolved at construction; the underlying stream is opened and closed per request, avoiding the try-with-resources-closes-too-early trap with lazy Response.stream writers.
Replaces the eager byte-buffering specHandler and removes the internal ClasspathResourceHandler. Content-Type inference now also covers .html, .css, and .js.