fix: Drop TypeMapper from exception and security paths#85
Merged
Conversation
Mirror PR #76's approach (HealthRenderer) for the problem+json wire shape. The default exception handler and SecurityFilter no longer route ProblemDetail through a TypeMapper; a hand-rolled ProblemDetailRenderer writes the fixed RFC 7807 shape directly, so the library emits problem responses without a JSON library on the classpath and without record-accessor reflection that GraalVM Native Image would otherwise need configured. Also replace the reflective GsonJsonMapper newInstance with a direct constructor call, still gated by the existing Class.forName Gson-presence probe. Drops the matching reflect-config entry for the constructor. Extract the shared JSON string-escape into internal/JsonStrings, used by both HealthRenderer and ProblemDetailRenderer. BREAKING CHANGE: Handlers.defaultExceptionHandler(TypeMapper) becomes defaultExceptionHandler(). SecurityFilter constructor drops its TypeMapper parameter.
thced
force-pushed
the
fix/exception-handler-type-mapper
branch
from
c606fde to
fee86f9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror PR #76's approach (HealthRenderer) for the problem+json wire shape. The default exception handler and SecurityFilter no longer route ProblemDetail through a TypeMapper; a hand-rolled ProblemDetailRenderer writes the fixed RFC 7807 shape directly, so the library emits problem responses without a JSON library on the classpath and without record-accessor reflection that GraalVM Native Image would otherwise need configured.
Also replace the reflective GsonJsonMapper newInstance with a direct constructor call, still gated by the existing Class.forName Gson-presence probe. Drops the matching reflect-config entry for the constructor.
Extract the shared JSON string-escape into internal/JsonStrings, used by both HealthRenderer and ProblemDetailRenderer.
BREAKING CHANGE: Handlers.defaultExceptionHandler(TypeMapper) becomes defaultExceptionHandler(). SecurityFilter constructor drops its TypeMapper parameter.