feat: Replace Spec.fromPath with Spec.fromClasspath#94
Merged
Conversation
The filesystem-path loader was awkward for the common case — every service ships its OpenAPI spec inside its own JAR. fromClasspath takes a Class<?> + resource name and dispatches on extension the same way, making the JAR-packaged case a one-liner. Removes fromPath(Path) and its test; adds fromClasspath(Class<?>, String) with tests covering JSON, YAML, YML, missing-resource, and unknown-extension cases. README updated with the new API and a note on the leading-slash gotcha in Class.getResourceAsStream.
Sonar S5778 — each lambda should have at most one invocation that can throw a runtime exception. Both getClass() and Spec.fromClasspath were inside the lambda; the call we're actually asserting against is Spec.fromClasspath, so pull the class lookup out into a local first.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filesystem-path loader was awkward for the common case — every service ships its OpenAPI spec inside its own JAR. fromClasspath takes a Class<?> + resource name and dispatches on extension the same way, making the JAR-packaged case a one-liner.
Removes fromPath(Path) and its test; adds fromClasspath(Class<?>, String) with tests covering JSON, YAML, YML, missing-resource, and unknown-extension cases. README updated with the new API and a note on the leading-slash gotcha in Class.getResourceAsStream.