Merged
Conversation
That was a code smell, violating basic principles (i.e. LSP)
The demo now accepts --keep-free on the command line to select the Z-algorithm variant (keeping free variables in the system), vs. the default which eliminates free variables first. A --help flag is also added. The Makefile gains run-demo-zalg and run-demo-compare targets, the latter showing both variants side by side via diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure and modernize dvrlib
This branch restructures the project layout, improves code quality, and extends tooling.
Project structure
for per-test colored output
Code quality
standalone classes with operator vector()/operator matrix() for copy-out
Φ⁻¹(0.975)
Build and tooling
Demo
Z-algorithm variant and a side-by-side comparison target (run-demo-compare)