Conversation
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="user/Kconfig">
<violation number="1" location="user/Kconfig:42">
P2: Misleading comment: the menu is NOT independent of main application choice. It explicitly depends on `USER_APP_TESTS || USER_APP_PINGPONG`, so it will be hidden when `USER_APP_NONE` is selected. Consider rewording to accurately describe the dependency.</violation>
<violation number="2" location="user/Kconfig:51">
P2: Misleading help text: LCD_TEST is NOT independent of main user application selection. It inherits the menu's `depends on USER_APP_TESTS || USER_APP_PINGPONG` dependency. Consider removing or correcting this statement.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This replaces two-step configuration process with direct application selection. Users now choose exactly one option: Test Suite, Pingpong Demo, or kernel-only build. Both hardware tests are only available when USER_APP_TESTS or USER_APP_PINGPONG is selected, and hidden when USER_APP_NONE is chosen.
53b4a85 to
b9e7ed9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces two-step configuration process with direct application selection. Users now choose exactly one option: Test Suite, Pingpong Demo, or kernel-only build.
Hardware test menu now depends directly on user application selection, hiding hardware tests when USER_APP_NONE is selected.
Summary by cubic
Simplifies configuration by replacing the two-step app setup with a single “User Application” choice: Test Suite, Pingpong Demo, or None. Improves build reliability by auto-regenerating autoconf.h when .config changes.
Refactors
Migration
Written for commit b9e7ed9. Summary will update on new commits.