Skip to content

Force background color to white, not transparent#141

Open
stoyle wants to merge 1 commit into
fabric-ds:nextfrom
stoyle:patch-1
Open

Force background color to white, not transparent#141
stoyle wants to merge 1 commit into
fabric-ds:nextfrom
stoyle:patch-1

Conversation

@stoyle

@stoyle stoyle commented Nov 29, 2022

Copy link
Copy Markdown

Should fix #140

@pearofducks

pearofducks commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

This breaks hover styling on the checkbox.

@stoyle

stoyle commented Dec 7, 2022

Copy link
Copy Markdown
Author

Oh wow, that's interesting! Good catch.

Seems specificity is higher on the "regular" ::before styling, than with hover. Creating a custom hover style for this case should be even more specific... But too complicated for such a small thing?

We can fix this with a custom selector in our podlet.

@stoyle

stoyle commented Dec 8, 2022

Copy link
Copy Markdown
Author

This fixes it for us: https://github.schibsted.io/finn/extended-profile-podium/commit/1b5e2f2bfa6cc43770e25498c1ab509612ae37ab

I still think this should live in fabric, not in our repo. But that is of course up to the fabric team.

By the way, the check mark is visible when hovering, but I guess that's a feature 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox needs background color

2 participants