docs(core): document Text's justify prop#3203
Merged
Merged
Conversation
durvesh1992
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
cixzhang
approved these changes
Jun 27, 2026
Contributor
|
Build is failing on this PR since main was briefly broken for the build step. It's been fixed now. Could you rebase this PR over latest main to get a green CI? |
Text supports a justify prop (TextJustify: 'start' | 'center' | 'end') but it was missing from the docsite properties tab — the same omission fixed for its sibling Heading in facebook#3176. Add it to Text's doc props. Found by scanning component interfaces vs their .doc.mjs prop lists.
cixzhang
force-pushed
the
fix/text-justify-prop-doc
branch
from
fe96540 to
98af464
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Textsupports ajustifyprop (TextJustify:'start' | 'center' | 'end', default'start') but it was missing from the docsite properties tab — the exact same omission I fixed for its siblingHeadingin #3176.Found by scanning component interfaces against their
.doc.mjsprop lists. AddedjustifytoText's doc props (aftertextWrap, matching interface order).Testing
justifynow appears in the Text component registry.Note
The same scan surfaced other props missing from various components' docs (e.g. Link's
type/size/weight/color/display, severalwidthprops). Those need per-prop judgment (some omissions are intentional for advanced/system props), so I'm keeping this PR scoped to the unambiguousjustifycase that mirrors the already-reviewed Heading fix. Happy to follow up on others if useful.Changeset
Included (
@astryxdesign/corepatch, docs).