Skip to content

[lexical-table] Bug Fix: Read background-color from shorthand style a… #8317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomsarduy wants to merge 1 commit into from
+66 −2
Closed

[lexical-table] Bug Fix: Read background-color from shorthand style a… #8317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/lexical-table/src/LexicalTableCellNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,12 @@ export function $convertTableCellNodeElement(
);

tableCellNode.__rowSpan = domNode_.rowSpan;
const backgroundColor = domNode_.style.backgroundColor;
if (backgroundColor !== '') {
const backgroundColor =
domNode_.style.backgroundColor ||
domNode_.style.background ||
domNode_.getAttribute('bgcolor') ||
null;
if (backgroundColor !== null) {
tableCellNode.__backgroundColor = backgroundColor;
}
const verticalAlign = domNode_.style.verticalAlign;
Expand Down
60 changes: 60 additions & 0 deletions packages/lexical-table/src/__tests__/unit/LexicalTableCellNode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,5 +368,65 @@ describe('LexicalTableCellNode tests', () => {
expect(node.getHeaderStyles()).toBe(TableCellHeaderStates.ROW);
});
});

test('DOM Conversion: <td> with style.backgroundColor reads inline background-color', async () => {
const {editor} = testEnv;

await editor.update(() => {
const td = document.createElement('td');
td.style.backgroundColor = '#F4B084';

const result = convertHTMLTag(td);
const node = expectTableCellNode(result);

// Browsers normalize hex to rgb when set via .style
expect(node.getBackgroundColor()).toBe(td.style.backgroundColor);
});
});

test('DOM Conversion: <td> with style.background shorthand (Excel/Outlook) reads background color', async () => {
const {editor} = testEnv;

await editor.update(() => {
const td = document.createElement('td');
td.style.background = '#F4B084';

const result = convertHTMLTag(td);
const node = expectTableCellNode(result);

// Browsers normalize hex to rgb; background may expand to backgroundColor
const expected =
td.style.backgroundColor || td.style.background || null;
expect(node.getBackgroundColor()).toBe(expected);
expect(node.getBackgroundColor()).not.toBeNull();
});
});

test('DOM Conversion: <td> with bgcolor attribute (legacy HTML) reads background color', async () => {
const {editor} = testEnv;

await editor.update(() => {
const td = document.createElement('td');
td.setAttribute('bgcolor', '#F4B084');

const result = convertHTMLTag(td);
const node = expectTableCellNode(result);

expect(node.getBackgroundColor()).toBe('#F4B084');
});
});

test('DOM Conversion: <td> with no background color sets backgroundColor to null', async () => {
const {editor} = testEnv;

await editor.update(() => {
const td = document.createElement('td');

const result = convertHTMLTag(td);
const node = expectTableCellNode(result);

expect(node.getBackgroundColor()).toBeNull();
});
});
});
});
Loading