Clarify Android AppState background for autofill credential pickers#5079
Conversation
|
@federicobartoli is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @federicobartoli! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey @federicobartoli, thanks for the update! 👍 Can you also backport he change into versioned docs? Also, to merge your contribution in we will require signing Meta CLA. |
Done, thanks! I backported the clarification to the versioned docs as requested. I have also completed the Meta CLA. It may just need some time for the check to refresh. |
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Thanks for the updates, welcome to the community! 🙂
Summary: Syncs the in-package AppState API documentation with the Android AppState clarification added in facebook/react-native-website#5079. Android AppState `background` was already documented as including another `Activity`. This clarifies that temporary system activities, such as autofill credential pickers, are included too. ## Changelog: [GENERAL] [CHANGED] - Clarify Android AppState background API documentation. Pull Request resolved: #56779 Test Plan: Documentation-only change. Verified with: - `git diff --check` - `prettier --check packages/react-native/Libraries/AppState/AppState.js packages/react-native/Libraries/AppState/AppState.d.ts` Reviewed By: cortinico Differential Revision: D104810583 Pulled By: huntie fbshipit-source-id: 17d2ec312c65c91b8086bd382f733f3cceb4da8a
2 participants
Summary
Clarifies that Android AppState
backgroundcan be emitted when anotherActivitytakes focus, including temporary system activities such as autofill credential pickers.Context
The AppState docs already mention that Android may report
backgroundwhen the user is on anotherActivity. This adds a concrete system-flow example where that distinction matters in practice, without changing the documented API behavior.Related: facebook/react-native#36420