[Hermes][CI] Remove dual Hermes version outputs from CI workflows#56704
Draft
cipolleschi wants to merge 6 commits intomainfrom
Draft
[Hermes][CI] Remove dual Hermes version outputs from CI workflows#56704cipolleschi wants to merge 6 commits intomainfrom
cipolleschi wants to merge 6 commits intomainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
cipolleschi
changed the title
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase4
branch
from
78b163f to
0d69970
Compare
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase5
branch
from
79eb124 to
f1541da
Compare
1 task
cipolleschi
changed the base branch from
cipolleschi/remove-legacy-hermes-phase4
to
main
Legacy Hermes support is no longer needed since 0.86 branch has been cut. This removes all dead code behind `!defined(HERMES_V1_ENABLED)` guards and the CMake infrastructure that set the HERMES_V1_ENABLED compile definition.
…solution Since legacy Hermes is no longer supported, remove the hermesV1Enabled toggle from the Gradle plugin, version.properties, and all build scripts. HERMES_V1_VERSION_NAME is renamed to HERMES_VERSION_NAME as the single Hermes version. CMake flags like HERMESVM_HEAP_HV_MODE are now unconditional.
…solution Since legacy Hermes is no longer supported, remove the hermesV1Enabled toggle from the Gradle plugin, version.properties, and all build scripts. HERMES_V1_VERSION_NAME is renamed to HERMES_VERSION_NAME as the single Hermes version. CMake flags like HERMESVM_HEAP_HV_MODE are now unconditional.
Remove the RCT_HERMES_V1_ENABLED environment variable and all conditional logic in the CocoaPods/Ruby files. The podspec now always reads HERMES_VERSION_NAME, uses V1 source files, and omits legacy inspector subspecs. The HERMES_V1_ENABLED=1 preprocessor define is no longer set since no C++ code checks for it.
Remove dual .hermesversion/.hermesv1version tag files — only .hermesversion remains. Simplify hermes-utils.js to single-tag operations, release scripts to single-version workflows, and bump-hermes-version.js to single Hermes. Remove legacy branch handling from release-hermes-for-branch-cut.js.
Simplify publish-release, create-draft-release, and prebuild-ios-core workflows to use a single HERMES_VERSION. Remove the Hermes V1 dSYM section from release notes. Delete unused prepare-hermes-v1-app action, hermes-v1.patch, and selectLatestHermesV1Version.js.
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase5
branch
from
f1541da to
3d96302
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D104381269. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-release.yml: removeHERMES_V1_VERSIONoutput, read onlyHERMES_VERSION_NAMEcreate-draft-release.yml: removehermesV1VersioninputcreateDraftRelease.js: removehermesV1Versionparameter and "Hermes V1 dSYMS" section from release notesprebuild-ios-core.yml: readHERMES_VERSION_NAMEinstead ofHERMES_V1_VERSION_NAMEprepare-hermes-v1-appaction,hermes-v1.patch, andselectLatestHermesV1Version.jsPrev PR: #56703
Changelog:
[Internal]
Test plan
yarn jest --no-watchman createDraftRelease-test.js— 9/9 tests pass