Remove stale disableMaintainVisibleContentPosition feature flag#56725
Open
fkgozali wants to merge 1 commit intofacebook:mainfrom
Open
Remove stale disableMaintainVisibleContentPosition feature flag#56725fkgozali wants to merge 1 commit intofacebook:mainfrom
fkgozali wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Remove the stale `disableMaintainVisibleContentPosition` feature flag which was never rolled out (defaultValue: false, expectedReleaseValue: false). This flag was intended to disable the `maintainVisibleContentPosition` prop in ScrollView but was never enabled. Changes: - Remove the feature flag definition from ReactNativeFeatureFlags - Simplify ScrollView.js by removing the unnecessary destructuring of `maintainVisibleContentPosition` (now passed through via otherProps spread) - Remove related generated code ## Changelog: [General][Removed] - Removed the unused `disableMaintainVisibleContentPosition` feature flag from ReactNativeFeatureFlags Differential Revision: D104195744
meta-cla
Bot
added
the
CLA Signed
|
@fkgozali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104195744. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the stale
disableMaintainVisibleContentPositionfeature flag which was never rolled out (defaultValue: false, expectedReleaseValue: false). This flag was intended to disable themaintainVisibleContentPositionprop in ScrollView but was never enabled.Changes:
maintainVisibleContentPosition(now passed through via otherProps spread)Changelog:
[General][Removed] - Removed the unused
disableMaintainVisibleContentPositionfeature flag from ReactNativeFeatureFlagsDifferential Revision: D104195744