Skip to content

Remove stale disableMaintainVisibleContentPosition feature flag (#56725) #56727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
+3 −28
Closed

Remove stale disableMaintainVisibleContentPosition feature flag (#56725) #56727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/react-native/Libraries/Components/ScrollView/ScrollView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import {
VScrollContentViewNativeComponent,
VScrollViewNativeComponent,
} from '../../../src/private/components/scrollview/VScrollViewNativeComponents';
import * as ReactNativeFeatureFlags from '../../../src/private/featureflags/ReactNativeFeatureFlags';
import AnimatedImplementation from '../../Animated/AnimatedImplementation';
import FrameRateLogger from '../../Interaction/FrameRateLogger';
import {findNodeHandle} from '../../ReactNative/RendererProxy';
Expand Down Expand Up @@ -1762,11 +1761,8 @@ class ScrollView extends React.Component<ScrollViewProps, ScrollViewState> {

const baseStyle = horizontal ? styles.baseHorizontal : styles.baseVertical;

const {
experimental_endDraggingSensitivityMultiplier,
maintainVisibleContentPosition,
...otherProps
} = this.props;
const {experimental_endDraggingSensitivityMultiplier, ...otherProps} =
this.props;
const props = {
...otherProps,
alwaysBounceHorizontal,
Expand Down Expand Up @@ -1819,10 +1815,6 @@ class ScrollView extends React.Component<ScrollViewProps, ScrollViewState> {
this.props.snapToInterval != null ||
this.props.snapToOffsets != null,
}),
maintainVisibleContentPosition:
ReactNativeFeatureFlags.disableMaintainVisibleContentPosition()
? undefined
: this.props.maintainVisibleContentPosition,
};

const {decelerationRate} = this.props;
Expand Down
11 changes: 0 additions & 11 deletions packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,17 +1065,6 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
disableMaintainVisibleContentPosition: {
defaultValue: false,
metadata: {
dateAdded: '2025-08-26',
description:
'Disable prop maintainVisibleContentPosition in ScrollView',
expectedReleaseValue: false,
purpose: 'experimentation',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: false,
metadata: {
Expand Down
8 changes: 1 addition & 7 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<ec712f5528e1e06486a9c471baba631b>>
* @generated SignedSource<<72c610dc5a8efc1eba2121949e1c24a0>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -32,7 +32,6 @@ export type ReactNativeFeatureFlagsJsOnly = $ReadOnly<{
animatedShouldDebounceQueueFlush: Getter<boolean>,
animatedShouldUseSingleOp: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
disableMaintainVisibleContentPosition: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixVirtualizeListCollapseWindowSize: Getter<boolean>,
Expand Down Expand Up @@ -161,11 +160,6 @@ export const animatedShouldUseSingleOp: Getter<boolean> = createJavaScriptFlagGe
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* Disable prop maintainVisibleContentPosition in ScrollView
*/
export const disableMaintainVisibleContentPosition: Getter<boolean> = createJavaScriptFlagGetter('disableMaintainVisibleContentPosition', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
Loading