[Fizz] Fix Suspense SSR content hidden for no-JS users (#35460)#35628
[Fizz] Fix Suspense SSR content hidden for no-JS users (#35460)#35628maxathy wants to merge 2 commits intofacebook:mainfrom
Conversation
Removed size-based outlining condition that caused large Suspense
boundaries to show fallback with a JS instruction to swap content.
Without JS, the content never appeared.
This change preserves defer={true} and suspensey content outlining,
but forces large content to inline, ensuring visibility for all users.
|
Hi @maxathy! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Removed size-based outlining condition that caused large Suspense boundaries to show fallback with a JS instruction to swap content. Without JS, the content never appeared.
This change preserves defer={true} and suspensey content outlining, but forces large content to inline, ensuring visibility for all users.
How did you test this change?
Added new regression test: Created
ReactDOMFizzServerNoScript-test.js
that verifies large Suspense content (>2000 bytes) appears in the initial HTML stream when using a small progressiveChunkSize (100). This confirms no-JS users will see the content instead of the fallback.