Skip to content

I added a test that asserts malformed profiling operations do not throw and that errors/warnings are logged#35674

Open
apoorvgarewal07 wants to merge 4 commits intofacebook:mainfrom
apoorvgarewal07:main
Open

I added a test that asserts malformed profiling operations do not throw and that errors/warnings are logged#35674
apoorvgarewal07 wants to merge 4 commits intofacebook:mainfrom
apoorvgarewal07:main

Conversation

@apoorvgarewal07
Copy link

  1. Builds minimal fake profiling data with a valid initial snapshot.
  2. Injects malformed operations (duplicate add, remove of missing node, remove root, and an unsupported op).
  3. Asserts that getCommitTree does not throw and that console.error / console.warn were called.

@meta-cla
Copy link

meta-cla bot commented Feb 2, 2026

Hi @apoorvgarewal07!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Feb 2, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant