I added a test that asserts malformed profiling operations do not throw and that errors/warnings are logged#35674
I added a test that asserts malformed profiling operations do not throw and that errors/warnings are logged#35674apoorvgarewal07 wants to merge 4 commits intofacebook:mainfrom
Conversation
apoorvgarewal07
commented
Feb 2, 2026
- Builds minimal fake profiling data with a valid initial snapshot.
- Injects malformed operations (duplicate add, remove of missing node, remove root, and an unsupported op).
- Asserts that getCommitTree does not throw and that console.error / console.warn were called.
…ow and that errors/warnings are logged
|
Hi @apoorvgarewal07! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |