Skip to content

Fix checkbox onChange not firing in certain click ordering cases#35704

Open
KashviYadav09 wants to merge 2 commits intofacebook:mainfrom
KashviYadav09:fix-checkbox-onchange-missing
Open

Fix checkbox onChange not firing in certain click ordering cases#35704
KashviYadav09 wants to merge 2 commits intofacebook:mainfrom
KashviYadav09:fix-checkbox-onchange-missing

Conversation

@KashviYadav09
Copy link

This change fixes an issue where checkbox onChange handlers were not
called in certain parent click event scenarios.

The ChangeEventPlugin now ensures checkbox and radio inputs always
enqueue change events when their value changes, aligning React
behavior with expected DOM semantics.

A regression test has been added.

@meta-cla
Copy link

meta-cla bot commented Feb 5, 2026

Hi @KashviYadav09!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant