Fix outlineWidth calc validation#1692
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Allow
outlineWidthto use the same width validator as border widths, which accepts CSS length expressions likecalc(...)while continuing to reject numeric strings such as"10".Added a focused regression test covering direct
outlineWidth: 'calc(...)'and nested pseudoselector value syntax.Linked PR/Issues
Fixes #1690
Additional Context
Tests run:
npm test --workspace @stylexjs/eslint-plugin -- --runTestsByPath __tests__/stylex-valid-styles-test.js --runInBand --coverage=falsenpx prettier --check packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.jsnpx eslint packages/@stylexjs/eslint-plugin/src/reference/cssProperties.js packages/@stylexjs/eslint-plugin/__tests__/stylex-valid-styles-test.jsgit diff --checknpm run build --workspace @stylexjs/eslint-pluginNote:
yarn install --frozen-lockfileinstalled dependencies and began the repo postinstall build, but the full monorepo build timed out while building docs after@stylexjs/eslint-pluginhad built successfully.Pre-flight checklist
Contribution Guidelines