Add nts.cookies_issued counter - #565
Closed
sofiascalzo wants to merge 4 commits into
Closed
Conversation
added 4 commits
July 23, 2026 09:56
Summary:
What this does:
- Adds two flags to the ntpresponder binary:
--enable-nts (default false) master switch for NTS
--nts-keystore-keys (default 2) master-key ring size for cookie sealing
- When --enable-nts is set, builds an in-memory cookie keystore via the existing
ntske.NewInMemoryKeystore and assigns it to server.Config.Keystore
Reviewed By: vvfedorenko
Differential Revision: D113043011
Summary: Add a dedicated `time/ntp/ntske/stats` package whose JSONStats satisfies `ntske.Stats` and `exports nts.ke.handshakes` and `nts.ke.errors` Reviewed By: pmazzini Differential Revision: D113220164
Summary: Seed the ntskeserver keystore with ntske.SharedTestMasterKey so cookies interoperate with the responder, and wire the dedicated ntske/stats.JSONStats into ntske.Server.Stats, exposed via --monitoringport. Uses the KE stats package, not responder/stats. Reviewed By: vvfedorenko Differential Revision: D113387496
Summary: Extend ntske.Stats with AddCookiesIssued(n); the KE server reports the number of NewCookie records after a successful response. Implement it in the dedicated ntske/stats package (nts.cookies_issued), keeping all KE metrics out of responder/stats. Reviewed By: pmazzini Differential Revision: D113225107
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@sofiascalzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113225107. |
Contributor
|
This pull request has been merged in 6946efe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Extend ntske.Stats with AddCookiesIssued(n); the KE server reports the number of NewCookie records after a successful response. Implement it in the dedicated ntske/stats package (nts.cookies_issued), keeping all KE metrics out of responder/stats.
Reviewed By: pmazzini
Differential Revision: D113225107