Add client-side NTS request/response helpers#567
Closed
sofiascalzo wants to merge 2 commits into
Closed
Conversation
added 2 commits
July 24, 2026 06:48
Summary: The KE handshake already derived the TLS-exporter session keys but threw them away, leaving a client no way to sign NTPv4 requests or verify responses. Return them from the handshake so the upcoming NTS NTPv4 client can use them. They are derived with the same exporter inputs as the server, so both ends agree. Reviewed By: vvfedorenko Differential Revision: D113419245
Summary: Adds reusable BuildNTPRequest and VerifyNTPResponse helpers, the client mirror of the server's request path, so the smoke client (and future NTS clients) can build authenticated NTPv4 requests and verify responses without duplicating the logic. Reviewed By: vvfedorenko Differential Revision: D113422499
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@sofiascalzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113422499. |
Contributor
|
This pull request has been merged in 1a68bc2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds reusable BuildNTPRequest and VerifyNTPResponse helpers, the client mirror of
the server's request path, so the smoke client (and future NTS clients) can build
authenticated NTPv4 requests and verify responses without duplicating the logic.
Reviewed By: vvfedorenko
Differential Revision: D113422499