Write scan state and raw measurements to the frame CSV - #6
Merged
Merged
Conversation
Append per-frame columns for the decoded frame size, fps, sampled pixel count, picture type, key frame flag, unclipped volume, luma percentiles and per-wedge luma means, and write pts at full precision. Name every header column; ProcessCSV parses the header by name and still accepts the old positional layout. With the new columns present, replay uses the recorded resolution and fps per frame instead of guessing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append per-frame columns for the decoded frame size, fps, sampled pixel count, picture type, key frame flag, unclipped volume, luma percentiles and per-wedge luma means, and write pts at full precision. Name every header column;
ProcessCSVparses the header by name and still accepts the old positional layout. With the new columns present, replay uses the recorded resolution and fps per frame instead of guessing.Verified on a recording: the live scan's block list and its replay from the new CSV match, and a legacy CSV still replays at the header's fps.