Skip to content

Convert P010/P016 hardware-decoder frames to 8-bit before analysis #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric merged 2 commits into from
Aug 30, 2026
Merged

Convert P010/P016 hardware-decoder frames to 8-bit before analysis #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c604a
Convert P010/P016 hardware-decoder frames to 8-bit before analysis
Jul 31, 2026
fa73f62
Convert any frame without 8-bit luma, free the replaced frame
eric Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions mpeg2dec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,9 +1020,12 @@ int SubmitFrame(AVStream *video_st, AVFrame *pFrame , double pts)
int res=0;
int changed = 0;
int line = 0;
const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(pFrame->format);

if (pFrame->format == AV_PIX_FMT_YUV420P10LE) {
line = 1;
if (!desc || desc->comp[0].depth != 8) {
Debug(1, "Panic: frame format %s is not 8-bit\n", desc ? desc->name : "?");
frame_ptr = NULL;
return(0);
}

// bitrate = pFrame->bit_rate;
Expand Down Expand Up @@ -1387,17 +1390,29 @@ static int prev_strange_framenum = 0;
while ((len1 = avcodec_receive_frame(is->dec_ctx, is->pFrame)) >= 0)
{
frameFinished = 1;
// convert to 8bit
if (is->pFrame->format == AV_PIX_FMT_YUV420P10LE) {
// convert anything without 8-bit luma to 8-bit
const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(is->pFrame->format);
if (desc && desc->comp[0].depth != 8) {
is->img_convert_ctx = sws_getCachedContext(is->img_convert_ctx, is->pFrame->width, is->pFrame->height, is->pFrame->format, is->pFrame->width, is->pFrame->height, AV_PIX_FMT_YUV420P, SWS_POINT, NULL, NULL, NULL);
AVFrame *newframe = av_frame_alloc();
if (!is->img_convert_ctx || !newframe) {
Debug(1, "Cannot convert %s frames to 8-bit\n", desc->name);
av_frame_free(&newframe);
av_frame_unref(is->pFrame);
continue;
}
av_frame_copy_props(newframe, is->pFrame);
newframe->format = AV_PIX_FMT_YUV420P;
newframe->width = is->pFrame->width;
newframe->height = is->pFrame->height;
av_frame_get_buffer(newframe, 0);
if (av_frame_get_buffer(newframe, 0) < 0) {
Debug(1, "Cannot allocate an 8-bit frame\n");
av_frame_free(&newframe);
av_frame_unref(is->pFrame);
continue;
}
sws_scale(is->img_convert_ctx, (const uint8_t * const *)is->pFrame->data, is->pFrame->linesize, 0, is->pFrame->height, newframe->data, newframe->linesize);
av_frame_unref(is->pFrame);
av_frame_free(&is->pFrame);
is->pFrame = newframe;
}

Expand Down
Loading