기능(#41): 템플릿 생성 POST API 연동#65
Open
TransparentDeveloper wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- TemplateValidationErrorType 에러 코드 유니온 정의 - validateTemplateInput(data) → 에러코드 or null - 정상 입력 케이스 테스트 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- TemplateInputType → CreateTemplateRequestType 변환 - AUCTION/DRAFT 분기, SEQUENTIAL→FIXED 매핑, captainsNeeded→teamCount - TODO: 백엔드 스펙 확장 후 tier/4종 gameType 반영 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- validate, mapper 모듈 re-export - exactOptionalPropertyTypes 위반 테스트 픽스
- MSW POST /api/v1/templates 핸들러 제거 (실서버 직접 호출) - .env.example에 PUBLIC_API_URL 안내 주석 추가 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- 방 만들기 클릭 시 POST /api/v1/templates 호출 후 mode별 이동 - validateTemplateInput 기반 버튼 활성 제어, 생성 중 표시, 실패 시 alert - 혼자 하기 버튼은 후속 이슈까지 disabled Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- import.meta.env → $env/dynamic/public로 전환 - PUBLIC_API_URL이 dev 브라우저에 주입되지 않던 문제 해결
7b961b8 to
3f525e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
POST /api/v1/templates실서버 연동 (템플릿 생성 폼 동작 구현 (/templates/create) #41 scope 확장)CreateTemplateRequest매핑captainsNeeded→teamCount,totalPoints→budget,minBid→minBidUnitdraftMode: SEQUENTIAL→draftOrderStrategy: FIXEDplayers[].tier제외 (백엔드 스펙 확장 예정, TODO 주석)validateTemplateInput순수 도메인 함수 추가 (9개 에러 코드)/auction/[id]·/draft/[id]이동POST /api/v1/templates핸들러 제거api-client:import.meta.env→$env/dynamic/public교체 (dev 환경 주입 문제 해결)미완료 (TODO)
gameType4종 /PlayerRequest.tier재반영테스트
bun run check— 신규 에러 0개 (기존 코드 에러 10건은 본 PR 무관)bun test— 102 pass (신규 validate 17 + mapper 6)bun run lint— 신규 이슈 0개