Skip to content

feat: add hubProtocol support to SignalR#44

Open
bgcurbani wants to merge 1 commit intofardad-dev:mainfrom
bgcurbani:add-support-for-other-hubprotocol
Open

feat: add hubProtocol support to SignalR#44
bgcurbani wants to merge 1 commit intofardad-dev:mainfrom
bgcurbani:add-support-for-other-hubprotocol

Conversation

@bgcurbani
Copy link
Copy Markdown

@bgcurbani bgcurbani commented Sep 13, 2025

Hello, I was in the middle of an implementation in my application using your library and realized I needed to use a protocol in SignalR called MessagePackProtocol. However, there was no way to change the default protocol through the library.

I made the changes in the PR to enable parameterization of this behavior.

Unfortunately, I needed to commit the change in the Socket.io section; otherwise, I couldn't commit. The Husky hook was preventing it due to compilation failure.

@ahmedrabii
Copy link
Copy Markdown

i like the same feature
+1

@fardad-dev
Copy link
Copy Markdown
Owner

it look good for me, we like to have same interface for all socket tools, is it possible for socket-io or websocket?

@ahmedrabii
Copy link
Copy Markdown

  • socket-io doesn’t have native MessagePack but you can use parser from socket.io-msgpack-parser to encode and decode messages
  • Plain WebSocket doesn’t have any enforced serialization format but you handle encoding/decoding manually
  • SignalR already supports MessagePack out of the box so it would be wise if the library could manage it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants