feat: add hubProtocol support to SignalR#44
Open
bgcurbani wants to merge 1 commit intofardad-dev:mainfrom
Open
feat: add hubProtocol support to SignalR#44bgcurbani wants to merge 1 commit intofardad-dev:mainfrom
bgcurbani wants to merge 1 commit intofardad-dev:mainfrom
Conversation
|
i like the same feature |
Owner
|
it look good for me, we like to have same interface for all socket tools, is it possible for socket-io or websocket? |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I was in the middle of an implementation in my application using your library and realized I needed to use a protocol in SignalR called MessagePackProtocol. However, there was no way to change the default protocol through the library.
I made the changes in the PR to enable parameterization of this behavior.
Unfortunately, I needed to commit the change in the Socket.io section; otherwise, I couldn't commit. The Husky hook was preventing it due to compilation failure.