Repository navigation
docs: explain why setup-php hangs on the pool and add a PHP derived image - #39
Merged
Merged
Conversation
Contributor
Author
|
Review of b79d6c7: ship. The supply-chain pins check out against their sources. Pins, verified independently
use-php
README claims against the evidence
Checks run
Not run
Not merged. |
…hp is the default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38.
Reproduction
Minimal workflow on the
railway-privatepool (branchci/setup-php-reproin parsilver/geonames-data, run 39194782759):setup-phpwith PHP 8.3 printssudo: a terminal is required to read the password/sudo: a password is requiredand then never returns; the step hit its 6 minutetimeout-minutesand left an orphansleep. The image has thesudobinary but the runner user has no rights (by design),sudo -n truefails, and setup-php'srun.shshells out tosudofor apt,lnandteeand waits instead of failing. No PHP is installed in the default image.Change
examples/php/Dockerfileanduse-php: derived image with PHP 8.3, 8.4 and 8.5 (ondrej/php PPA, key pinned by fingerprint) and Composer (pinned by version and sha256);use-php <version>puts that version first on PATH for the later steps with no root, so a workflow drops the setup-php step.timeout-minuteson steps.example-phpjob builds the image and runsuse-phpfor each version.Evidence
Local build of
examples/php(linux/amd64): as therunneruser,use-php 8.3|8.4|8.5prints the matching PHP version, mbstring loads,composer --versionis 2.10.3, and viaGITHUB_PATHphpresolves to the shim. Not yet run on the pool: the image still needs to be published and set asRUNNER_IMAGEfor a controller (own label and prefix) before the two PHP repos can use it. The sudo variant as the other route is untested with setup-php and said so in the README.