Repository navigation
feat(image): add the GitHub CLI, pinned by version and sha256 - #42
Merged
Merged
Conversation
Scripts that open or comment on issues (gh issue create) could not run on the pool, so workflows kept those jobs on GitHub-hosted runners. gh is verified against the release sha256 at build time and checked in the build's tool loop and the php smoke job. Nothing is logged in.
Contributor
Author
|
Code review at 5b415e5: ship
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
gh2.102.0 to the base stage, so every variant (base, php, pg, redis, sudo) has it.sha256sum -cagainst the digest in the release'sgh_2.102.0_checksums.txt(I downloaded the asset and computed the same sha256 myself).GH_TOKEN.gh, and the php smoke job runsgh --version.Why: the PHP repos'
reportjobs runbin/report-issue(gh issue create) and holdissues: write; the pool image had no gh, so they had to stay on GitHub-hosted runners. After this merges and the image rebuilds, those jobs move to the pool.Not run here: the Docker build itself (CI does it; the local machine is arm64).