Conversation
|
@victor1234 Do you know why it fails under Visual Studio? |
|
PR is not complete now, I need 1-2 days |
README.md
Outdated
| ---------------- | ||
|
|
||
| ``` | ||
| cmake -DCMAKE_BUILD_TYPE=Release .. |
There was a problem hiding this comment.
Still good to spell it out because under Windows, it must be spelt out.
README.md
Outdated
| Installation (CMake) | ||
| ---------------- | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Missing "mkdir build?". Note that you can do cmake -B build ....
|
@lemire PR is in draft mode now. I'm still working. It's not ready for review. |
|
This is a comprehensive PR and I would like to discuss whether these changes are suitable for your project. The main goal is to create modern cmake targets that install correctly and are available through various integration methods, making it easier to use the library and build packages for it. In addition, global variables are not used in modern cmake (they are propagated to the main project when the library is integrated via Please answer these questions:
|
README.mdwithCMakeintegration instructionsfind_package(streamvbyte)check toUbuntu 22.04CI