Skip to content

Add pending flag for SoonValue#497

Closed
shuofengzhang wants to merge 1 commit intofastapi:mainfrom
shuofengzhang:add-soonvalue-pending
Closed

Add pending flag for SoonValue#497
shuofengzhang wants to merge 1 commit intofastapi:mainfrom
shuofengzhang:add-soonvalue-pending

Conversation

@shuofengzhang
Copy link

What changed

  • add a pending property on SoonValue as a clear inverse of ready
  • cover the new flag behavior with a small unit test

Why

  • the docs and examples already reference soon_value.pending; adding the property aligns behavior with the documented API and avoids AttributeError surprises

Testing

  • pytest -q

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this flag, as the inverse .ready already exists. There was one docstring that incorrectly referenced .pending and this has been fixed, cf #269. Closing this one.

@svlandeg svlandeg closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants