Tests: ensure default values appear in help output #1479
Closed
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
reviewed
Jan 6, 2026
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
Did you double check that none of the existing tests currently already test for this?
svlandeg
reviewed
Jan 6, 2026
| else: | ||
| typer.echo(f"Hi {name}!") | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Code duplicated from https://github.com/fastapi/typer/pull/1478/files
Author
|
Hi @svlandeg Yes I have checked and looks like it is not covered |
svlandeg
reviewed
Jan 7, 2026
Member
svlandeg
left a comment
svlandeg
left a comment
There was a problem hiding this comment.
There are plenty of tests already covering this, e.g. https://github.com/fastapi/typer/blob/master/tests/test_tutorial/test_arguments/test_help/test_tutorial006.py#L25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test to ensure default parameter values are displayed in Typer
command help output.
Motivation
Help output is part of the CLI user experience. This test ensures that
default values remain visible and prevents accidental regressions.
Changes
--helpNotes
No production code changes.