♻️ Improve how we handle invalid tokens#153
Merged
Conversation
patrick91
force-pushed
the
isolate-tests-from-config
branch
2 times, most recently
from
8449177 to
19256d8
Compare
patrick91
force-pushed
the
improve-how-we-handle-invalid-tokens
branch
2 times, most recently
from
7c411fd to
314a0e7
Compare
patrick91
commented
Feb 10, 2026
Comment on lines
+92
to
+96
| if e.status_code == 404: | ||
| message = "App not found. Make sure to use the correct account." | ||
|
|
||
| elif isinstance(e.__cause__, HTTPError): | ||
| message = handle_http_error(e.__cause__) |
Collaborator
Author
There was a problem hiding this comment.
I'm thinking of turning StramLogError into an HTTPError, but I would love to still retain "App not found. Make sure to use the correct account.", I might do some more refactoring in another PR (my current ideas is that we could pass a Mapping[StatusCode, ErrorMessage] to handle_http_error)
patrick91
force-pushed
the
isolate-tests-from-config
branch
from
19256d8 to
1c6abfe
Compare
patrick91
force-pushed
the
improve-how-we-handle-invalid-tokens
branch
2 times, most recently
from
769a318 to
2c9e0ca
Compare
patrick91
force-pushed
the
improve-how-we-handle-invalid-tokens
branch
2 times, most recently
from
18b2573 to
ba30f49
Compare
patrick91
force-pushed
the
improve-how-we-handle-invalid-tokens
branch
4 times, most recently
from
4b7b2cf to
f686471
Compare
buurro
requested changes
Feb 12, 2026
Shortcake-Parent: main
patrick91
force-pushed
the
improve-how-we-handle-invalid-tokens
branch
from
f686471 to
1412b7d
Compare
buurro
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the existing tokens when we get a 401
Stack
allow-to-specify-application-directory)improve-how-we-handle-invalid-tokens) <-- this PRisolate-tests-from-config)