fix: remove runtime dependency on @fastify/secure-session - #168
Merged
Conversation
Tony133
marked this pull request as ready for review
August 13, 2026 17:01
Tony133
marked this pull request as draft
August 13, 2026 17:02
Tony133
marked this pull request as ready for review
August 13, 2026 17:12
Tony133
marked this pull request as draft
August 13, 2026 17:17
Tony133
force-pushed
the
fix/remove-secure-session-import
branch
from
August 13, 2026 17:28
1cf6ddc to
0dd49fd
Compare
Tony133
marked this pull request as ready for review
August 13, 2026 17:30
Tony133
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
@fastify/secure-sessionimport fromsrc/index.ts.SessionDatainsrc/flash.tsand deriveFlashDatafromSessionData['flash'].src/index.tsis preserved in the generatedlib/index.js, causing@fastify/flashto require@fastify/secure-sessionat runtime.@fastify/secure-sessionis only required as a type/development dependency, removing the runtime import prevents it from becoming a production dependency.Fixes #167