Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cacheControl()andstaticCache()convert string times with@lukeed/msand then only checktypeof time === 'number'.ms()returnsundefinedfor a string it can't parse, so the time becomesNaN, passes the check and ends up in the header:Caches treat these directives as invalid, and nothing tells the developer.
A shared
toSeconds()helper now converts the time and asserts that it is a finite, non-negative number.maxAge()andstale()go throughcacheControl(), so they are covered too. Valid inputs keep producing the same headers.Tests cover an unparsable string,
NaN,Infinityand a negative number.npm testpasses, including 100% coverage and the type tests, and so doeseslint.Checklist
npm run test