feat(QuickStart): replace Docusaurus CodeBlock styles#445
Conversation
Thanks for the review! You're absolutely right, the default configuration supports these features. The primary reason was purely aesthetic: I wanted to give the homepage/QuickStart a more customized and polished look. The goal was just to make the homepage a little bit nicer! 🙂 As I had started doing in this PR: #443 |
I get it, but then why not opting for customizations through CSS? Is it something you considered or did you have any problem with it? |
I’ll try to see what I can do by tweaking the CSS a little, without creating any custom components 💪🏻 |
Thank you so much, please keep me posted! |
7bf5f0a to
34fe371
Compare
| @@ -0,0 +1,99 @@ | |||
| .subLabel { | |||
There was a problem hiding this comment.
Considering that you are wrapping everything with the qsCodeBlock class, do you still need this?
There was a problem hiding this comment.
Considering that you are wrapping everything with the qsCodeBlock class, do you still need this?
removed, see commit here: b2b0097
| .qsCodeblock [role='tabpanel'], | ||
| .qsCodeblock [class*='codeBlockContainer'], | ||
| .qsCodeblock [class*='codeBlockContent'] pre { | ||
| margin: 0 !important; |
There was a problem hiding this comment.
Are these important really needed?
Maybe by using a more specific selector we can get rid of them
There was a problem hiding this comment.
Are these important really needed? Maybe by using a more specific selector we can get rid of them
see commit here: dee94c9


Proposal:
CodeBlockfunction in theme directorystyles.module.cssinQuickStartdirectoryindex.jsxinQuickStartdirectorycc @fastify/frontend @fastify/website