Skip to content

Conversation

@anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Dec 19, 2025

Change summary

Add support for NGWAF rule manipulation. create and update are handled by allowing the user to proved a valid json that can be unmarshalled to the matching structure for the given rule level.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1222-ngwaf-rules branch 6 times, most recently from fabc92c to ca877a2 Compare December 19, 2025 17:56
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review December 19, 2025 18:15
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner December 19, 2025 18:15
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential small area for improvement, otherwise looks good.

Thanks for putting a considerable effort into this PR!

@anthony-gomez-fastly anthony-gomez-fastly merged commit a3be1a3 into main Jan 7, 2026
13 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1222-ngwaf-rules branch January 7, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants