Update wicked_pdf 1.4.0 -> 2.8.2 (hold wkhtmltopdf-binary at 0.12.3.1)#90
Merged
Conversation
wicked_pdf was exact-pinned at 1.4.0 (2019); bump the maintained Ruby gem to 2.8.2. The render pdf: usage and wicked_pdf_stylesheet_link_tag / wicked_pdf_image_tag helpers are unchanged in 2.x; no initializer to migrate. wkhtmltopdf-binary is deliberately HELD at 0.12.3.1. Bumping it to 0.12.6.10 segfaulted (SIGSEGV) in the Linux runtime (CI, and by extension Heroku), and wkhtmltopdf 0.12.6 also blocks local file access by default (breaking the PDF logo/stylesheet). wkhtmltopdf is EOL, so 0.12.3.1 — the binary production already runs — stays. Used --conservative; rack stays at 2.x. Both lockfiles updated. Verified locally: PDF controller test green, full suite 16/52/0, rubocop + reek clean, and a live server upload -> PDF download returns a valid %PDF.
JuanVqz
force-pushed
the
chore/update-wicked-pdf
branch
from
b1c80ee to
19aab25
Compare
JuanVqz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
wicked_pdf1.4.0 → 2.8.2.wkhtmltopdf-binaryis intentionally held at 0.12.3.1 (not bumped).Why
wicked_pdfwas exact-pinned at 1.4.0 (2019). Bumping the maintained Ruby gem to 2.8.2 is safe: therender pdf:call and thewicked_pdf_stylesheet_link_tag/wicked_pdf_image_taghelpers are unchanged in 2.x, and there's nowicked_pdfinitializer to migrate.Why the binary is held at 0.12.3.1: I first tried bumping
wkhtmltopdf-binaryto 0.12.6.10, but CI caught two problems that would also hit production (same Linux binary on Heroku):wkhtmltopdf is EOL (0.12.6 is the last release), so rather than fight an unstable binary, the binary stays at 0.12.3.1 — the exact version production already runs successfully. Only the Ruby gem moves.
Changes
Gemfile:wicked_pdf "1.4.0"→"~> 2.8";wkhtmltopdf-binarykept at"0.12.3.1"with an explanatory comment--conservativebundle;rackunchanged; both lockfiles updatedVerification
test_show_with_the_PDF_format_renders_a_PDF_successfully) — greenrubocop+reekclean%PDF