Update minitest 5.27.0 -> 6.0.6 (add minitest-mock)#95
Merged
Conversation
Removes the deliberate `< 6` pin and moves to minitest 6.0.6. minitest 6.0 extracted minitest/mock into a separate minitest-mock gem, and this suite uses it (`require "minitest/mock"` + `.stub` in gemfile_test.rb and bundler_audit_database_preparer_test.rb), so minitest-mock is added explicitly — exactly the split the old pin's comment anticipated. Both lockfiles updated; --conservative kept rack at 2.x. Verified locally: minitest 6.0.6 does not ship mock.rb; minitest-mock supplies it; full suite green (16 runs, 53 assertions, 0 failures) with the .stub-based tests passing; boots; rubocop + reek clean.
JuanVqz
force-pushed
the
chore/update-minitest
branch
from
a83b42d to
f784250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates
minitest5.27.0 → 6.0.6, removing the deliberate< 6pin, and addsminitest-mock.Why
The
< 6pin was intentional: minitest 6.0 extractedminitest/mockinto a separateminitest-mockgem, and this suite depends on it —require "minitest/mock"and.stubintest/models/gemfile_test.rbandtest/lib/bundler_audit_database_preparer_test.rb. Moving to 6.0 therefore requires declaringminitest-mockexplicitly. This is exactly the split the old pin's comment anticipated; it's now handled rather than avoided.Changes
Gemfile:gem "minitest", "< 6"→gem "minitest"+gem "minitest-mock"(comment updated)Gemfile.lockandGemfile.next.lockupdated (--conservative;rackunchanged)Verification
minitest/mock.rb;minitest-mocksupplies it.stub-based tests passrubocopclean (exact CI config);reekclean