Conversation
There was a problem hiding this comment.
Pull request overview
Adds Selectors Level 4 support for :nth-child(An+B of S) / :nth-last-child(An+B of S) and adjusts :enabled to only match relevant form controls.
Changes:
- Extend nth-family pseudo filter compilation to handle the optional
of <selector-list>clause. - Update
:enabledalias to restrict matching to form-related elements and exclude:disabled. - Add tests covering
:enabledand:nth-child(... of ...)/:nth-last-child(... of ...).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/pseudo-classes.ts |
Adds test coverage for :enabled and :nth-*(... of ...) behavior. |
src/pseudo-selectors/index.ts |
Passes compileToken through to filter compilers to enable nested selector compilation. |
src/pseudo-selectors/filters.ts |
Implements of-clause handling for nth-child / nth-last-child and refactors nth logic. |
src/pseudo-selectors/aliases.ts |
Fixes :enabled alias to only target form-control-like elements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ofin nth pseudo classes, e.g.:nth-last-child(1 of .a)