Fix WriteMultiVars padding when last item has odd bytes #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WriteMultiVars function that incorrectly applied padding after the last data item when it had an odd number of bytes, causing write failures.
Changes
Problem
The original code:
Applied padding to ALL odd-sized items, including the last one, corrupting the packet.
Solution
Only applies padding between items.
Protocol Reference
According to reverse-engineered S7 protocol documentation:
Source: The Siemens S7 Communication - Part 2 Job Requests and Ack Data
The key requirement is padding only when there is a following Data Item - not after the last item.