Repository navigation
Open the app after install, and stop the Node.js 20 warning - #12
Merged
Merged
Conversation
microsoft/setup-msbuild@v2 targets Node.js 20, which GitHub has deprecated, and every Windows job warned about it. A pwsh step runs the same vswhere query and adds MSBuild to PATH. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cT9EAowbsvsKBpXwTnKLN
The wizard's last page gets an "Open SimpleDeFence" box, ticked by default, which starts the app through WixShellExec so Windows can show the elevation prompt. With the wizard, the commit-phase launch actions did not open the app, so they now run only for silent and basic-UI installs such as the in-app update. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cT9EAowbsvsKBpXwTnKLN
With "replace" ticked, the run deletes the release and its tag before publishing it again from the current commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cT9EAowbsvsKBpXwTnKLN
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cT9EAowbsvsKBpXwTnKLN
fcoltro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Fabio · project thread
Before: the app did not open after installing 1.0.2 with the wizard. Every Build and Release job warned "Node.js 20 is deprecated", naming
microsoft/setup-msbuild. A release could not be rebuilt under the same tag.After: the wizard's last page has an "Open SimpleDeFence" box, ticked by default. CI no longer warns about Node 20. A manual Release run can replace an existing release.
How:
WixShellExecfrom the wizard's own process, so Windows can show the elevation prompt. The commit-phase launch actions now run only whenUILevel < 5, meaning silent and basic-UI installs such as the in-app update. This avoids opening the app twice.vswherequerysetup-msbuildran and adds MSBuild toGITHUB_PATH, inbuild.ymlandrelease.yml.replaceinput deletes the release and its tag before republishing.The installer change has not been run on Windows.
🤖 Generated with Claude Code
https://claude.ai/code/session_014cT9EAowbsvsKBpXwTnKLN