Remove remote dataset retrieval for tests#946
Open
Nacho888 wants to merge 5 commits into
Open
Conversation
Nacho888
marked this pull request as ready for review
July 18, 2026 14:43
solegalli
reviewed
Jul 19, 2026
solegalli
left a comment
Collaborator
There was a problem hiding this comment.
Hi @Nacho888
Thank you very much for this PR. We definitely need to step away from making urlib calls in our tests.
I think for simpler transformers like the discretiser, we could replace the california housing by a hard coded dataframe, and then we don't store a csv file.
For more complex transformers, like MRMR, we could try creating an artificial dataset with make_classification and see if that resolves the issue, before committing to storing a csv file as part of the test suite.
It would be good as a start, to understand which tests rely of this dataset, so we know how big a change we need if we were to replace it completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all calls to
fetch_california_housingfrom the tests, so that no internet connection is required for the execution of these. This is a small optimization but more in line with the best practices of avoiding making these type of connections while executing the test suite.It removes an external dependency, and might make it slightly faster - at the expense of the addition of an extra file. This file will only be available for tests and the won't be bundled in the end-user package.
This pattern might need to be extended to other tests that make use of other remote datasets.