chore(deps): move templates onto the SDKs that allow skipping a passkey - #33
Merged
Conversation
Registration used to end on a screen with one control on it. A user who did not want a passkey, or whose device could not make one, had no way forward. @seamless-auth/react 0.8.0 offers a skip when the instance has a login method other than passkey enabled, and says plainly when it does not. The web and API templates move together because the feature spans them. The skip is gated on reading GET /system-config/public from the auth server, and the adapters serve routes from an explicit list, so a React template on 0.8.0 needs an API template that proxies the new route. Upgrading the web templates alone would leave the read failing and the skip permanently hidden. @seamless-auth/react 0.7.0 -> 0.8.0 (both React templates) @seamless-auth/express 0.11.0 -> 0.12.0 @seamless-auth/fastify 0.2.0 -> 0.3.0 Verified with npm run validate, and with npm install and npm run build in all four templates the way CI does it, plus npm run lint in both API templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the passkey-skip work that just shipped across the SDKs.
What this gives a scaffolded app
Registration used to end on a screen with one control on it: "Register Passkey". No skip, no back. And if the device did not support passkeys it rendered "Passkeys are not supported on this device." and nothing else, on a screen the user could not leave.
@seamless-auth/react0.8.0 offers a skip when the instance has a login method other thanpasskeyenabled, and tells the user plainly when it does not. The session already exists at that point, since the OTP step that leads there establishes it, so finishing without a passkey was always valid and simply was not offered.Why all four templates move in one PR
The feature spans web and API. The skip is gated on reading
GET /system-config/publicfrom the auth server, and the adapters serve routes from an explicit allowlist, so a React template on 0.8.0 needs an API template that proxies the new route.Upgrading the web templates alone would leave the read failing and the skip permanently hidden. It degrades safely (unknown methods means no skip, never a skip that strands someone) but the feature would silently not work, which is worse than not shipping it.
@seamless-auth/react@seamless-auth/express@seamless-auth/fastifyBoth React templates move together so
--basicand--oauthdo not diverge.Verification
npm run validatecleannpm installandnpm run buildin all four templates, the way CI does it: react-vite, react-oauth, express, fastify all greennpm run lintclean in both API templatesuseLoginMethodsin the React types,system-config/publicin both adapter bundles)Lockfiles regenerated. Minor changeset included.