Drop Linux ARM64, and make CI link the four real targets - #11
Merged
Merged
Conversation
The requested targets are Windows x64, Windows ARM64, macOS ARM64 and Linux x64. Linux ARM64 was added on top of those, and it is what caused v1.1.0 to publish an incomplete set of assets: the cross compiler was installed without a target C library, so both ARM64 jobs failed to link. Removes the target from the release matrix, returns Debian and RPM packaging to a single x86-64 job, and takes the row back out of the README install table. No asset for it was ever published, so nothing that anyone could have installed goes away. Keeps the one useful thing that came out of the failure: the CI targets job now runs `cargo build --release` rather than `cargo check`. `check` does not link, so a link error could not surface until a release ran. Building the four real targets on every pull request closes that gap whatever the target list is. Also records the pull-request title convention that produced a duplicated 1.1.0 changelog entry: with a merge commit, prefix the title or the commits, not both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux ARM64 was never a requested target. The requested set is Windows x64,
Windows ARM64, macOS ARM64 and Linux x64 — and Linux ARM64 is what caused
v1.1.0 to publish an incomplete set of assets.
Removed
aarch64-unknown-linux-gnufrom the release matrix;No ARM64 asset was ever published, so nothing anyone could have installed
goes away. The four targets in the release matrix now match the four in CI
and the four in the README.
Kept
CI builds rather than checks.
cargo checkdoes not link, so a linkerror stayed invisible until a release ran — which is how v1.1.0 shipped
incomplete. The targets job now runs
cargo build --releasefor all fourtargets, so a link failure appears on the pull request that causes it. Worth
having regardless of which targets exist; say if you would rather have the
faster
checkback.The pull-request title convention, now in
CONTRIBUTING.md: with a mergecommit, prefix the title or the commits, not both, or the change is counted
twice. That is what produced the duplicated line in the 1.1.0 changelog.
Version
fix:, so 1.1.1. Removing a platform that never shipped an artefact is not abreaking change.