fix(generator-cli): consume FAI NDJSON heartbeat stream in AutoVersionStep - #17639
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
fix(generator-cli): consume FAI NDJSON heartbeat stream in AutoVersionStep#17639devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
AI Review Summary
Adds NDJSON streaming support to AutoVersionStep's FAI call with a content-type negotiated fallback to plain JSON. Logic is mostly sound; a couple of robustness nits around CRLF/\r handling and unknown event types being fatal.
- 🟡 1 warning(s)
- 🔵 2 suggestion(s)
To request another review, comment /ai-review on this pull request.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…empty result Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: Refs (none)
Client half of fern-api/fern-platform#14449.
AutoVersionStep.analyzeViaFaiServicenow sendsAccept: application/x-ndjsontoPOST /sdks/analyze-commit-diffso FAI can stream heartbeat lines while a multi-minute analysis of a large SDK diff runs, instead of sitting silent past the ALB idle timeout (the 504s that motivated fern-api/fern-platform#14376).Behavior is negotiated on the response
Content-Type, so a FAI deployment that has not picked up the server change (or any non-streaming proxy) still works via the existingresponse.json()path.Changes Made
AutoVersionStep.ts: addAcceptheader; when the response isapplication/x-ndjson,readFaiAnalyzeStreamreadsresponse.bodyline by line:ndjsonResponsehelper that splits the stream across arbitrary chunk boundaries; new cases for heartbeats-then-result, in-band error, and truncated stream; assert theAcceptheader on the existing plain-JSON test.changes/unreleased/autoversion-fai-ndjson-stream.yml(fix).Testing
auto-version-step.execute.test.ts: 44 passedpnpm turbo run compile --filter @fern-api/generator-cliclean;biome checkcleanRollout: FAI PR deploys first (harmless either way, since the header is opt-in on both sides); generators pick this up on their next version bump/Docker rebuild once the catalog pin is updated.
Link to Devin session: https://app.devin.ai/sessions/7e579645945144bd8566e4a37d79ae66
Open in Devin Desktop: https://app.devin.ai/desktop/session/7e579645945144bd8566e4a37d79ae66?variant=devin