chore(seed): update all seed snapshots - #17663
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![nitpickybot[bot]](https://avatars.githubusercontent.com/in/2901896?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Review Summary
Auto-generated seed snapshot PR adding the auto-generate-idempotency-key Go SDK fixture. Code is generator output and looks consistent with existing seed snapshots. One dead-code smell worth noting upstream: core.SetIdempotencyKeyHeader/GenerateIdempotencyKey are defined but the diff shows nothing wiring them into the request path (IdempotentRequestOptions.ToHeader only sets the key when explicitly supplied), which would defeat the point of the new feature.
- 🟡 1 warning(s)
- 🔵 1 suggestion(s)
To request another review, comment /ai-review on this pull request.
| func (i *IdempotentRequestOptions) ToHeader() http.Header { | ||
| header := i.RequestOptions.ToHeader() | ||
| if i.IdempotencyKey != "" { | ||
| header.Set("Idempotency-Key", fmt.Sprintf("%v", i.IdempotencyKey)) | ||
| } |
There was a problem hiding this comment.
🟡 warning
ToHeader only sets Idempotency-Key when the user supplied one — nothing here calls SetIdempotencyKeyHeader. For a fixture named auto-generate-idempotency-key, that looks like the auto-generation path is never actually exercised (the helpers in core/idempotency.go appear unused). Worth verifying the generator wires SetIdempotencyKeyHeader(header) in before returning.
| opts ...FileParamOption, | ||
| ) *FileParam { | ||
| return &FileParam{ | ||
| Reader: reader, | ||
| filename: filename, | ||
| contentType: contentType, | ||
| } | ||
| } |
There was a problem hiding this comment.
🔵 suggestion
opts ...FileParamOption is accepted but never applied, so go vet/linters may flag the unused parameter and callers get silent no-ops. Fine if intentional as an extensibility hook, but a _ = opts or a comment would make it explicit.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
Auto-generated combined seed update PR.
Trigger: push from branch: main.
Workflow run: https://github.com/fern-api/fern/actions/runs/33911546097